Adjust Github Actions to use Helm deployment - #2
Conversation
| #### Example | ||
|
|
||
| ```yaml | ||
| - uses: ./.github/actions/helm-deploy |
There was a problem hiding this comment.
| - uses: ./.github/actions/helm-deploy | |
| - uses: aboutbits/github-actions-kubernetes/helm-deploy@v1 |
There was a problem hiding this comment.
What do you think about renaming aboutbits/github-actions-kubernetes/deploy to aboutbits/github-actions-kubernetes/kubectl-deploy? We could just simply release everything with version 2 then it should not be a problem and we have it more evident for the future?
| | `working-directory` | `.` | The working directory | | ||
| | `chart-path` | `.` | Path to the Helm chart | |
There was a problem hiding this comment.
Here you are referencing twice a folder, but one time you call it directory and one time path. Would it make sense to align the names?
| chart-path: | ||
| description: 'Path to the Helm chart' |
There was a problem hiding this comment.
| chart-path: | |
| description: 'Path to the Helm chart' | |
| chart-directory: | |
| description: 'The directory of the Helm chart' |
|
|
||
| ```yaml | ||
| - uses: aboutbits/github-actions-kubernetes/deploy@v1 | ||
| - uses: aboutbits/github-actions-kubernetes/kubectl-deploy@v2 |
There was a problem hiding this comment.
Please adjust also the title: Deploy to Kuberentes using kubectl.
alexlanz
left a comment
alexlanz
left a comment
There was a problem hiding this comment.
`
git tag v1
git push --tagsReplacing an already existing minor release:
git tag -d v1
git push origin :refs/tags/v1
git tag v1
git push --tags`
There was a problem hiding this comment.
When I increace the verison, then I adjust also always in the readme under the section Versioning all the references of v1 to v2.
3 participants
No description provided.